Skip to content

add logics to support suborchestration - #21

Merged
kaibocai (kaibocai) merged 1 commit into
mainfrom
kaibocai/suborchestration-logics
Apr 1, 2022
Merged

kaibocai (kaibocai) merged 1 commit into
mainfrom
kaibocai/suborchestration-logics

Conversation

@kaibocai

@kaibocai kaibocai (kaibocai) commented Mar 31, 2022 •

Copy link
Copy Markdown
Member

This PR contains changes for issue #5 :

Add logics to support suborchestration
Add intergration tests

@kaibocai

Copy link
Copy Markdown
Member Author

TODO: code udpate
issue: microsoft/durabletask-dotnet#9

@cgillum Chris Gillum (cgillum) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two comment fixes but otherwise I think we can merge this!

Comment thread sdk/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java Outdated
Comment thread sdk/src/test/java/com/microsoft/durabletask/ErrorHandlingIntegrationTests.java Outdated
@cgillum Chris Gillum (cgillum) linked an issue Mar 31, 2022 that may be closed by this pull request

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, but overall lgtm

Comment thread sdk/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java Outdated
Comment thread sdk/src/main/java/com/microsoft/durabletask/TaskOrchestrationExecutor.java Outdated
@kaibocai
kaibocai (kaibocai) force-pushed the kaibocai/suborchestration-logics branch from 37686aa to 7b616ee Compare April 1, 2022 02:59
@kaibocai
kaibocai (kaibocai) merged commit 12d2038 into main Apr 1, 2022
@kaibocai
kaibocai (kaibocai) deleted the kaibocai/suborchestration-logics branch April 1, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sub-orchestration support

3 participants